fix: skip behaviour and recursive copying #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously setting bundling to `undefined` would make the AssetStaging in CDK copy the rootDir into the cdk.out folder. If the cdk.out folder was part of the rootDir then this caused recursive copying and an eventual error. Calling `cdk list` would trigger this as it sets `bundlingRequired` to `false` which sets `skip` to true. The code now handles `skip` being true and doesn't try to find Python versions or do anything that would require the actual asset contents to be there. Tests are updated to align more with how the code is called when ran by CDK.
chrismcg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously setting bundling to
undefinedwould make the AssetStaging in CDK copy the rootDir into the cdk.out folder. If the cdk.out folder was part of the rootDir then this caused recursive copying and an eventual error. [1]Calling
cdk listwould trigger this as it setsbundlingRequiredtofalsewhich setsskipto true.The code now handles
skipbeing true and doesn't try to find Python versions or do anything that would require the actual asset contents to be there.Tests are updated to align more with how the code is called when ran by CDK.
[1] https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/core/lib/asset-staging.ts#L194-L201 is where
stageByCopying()gets called when bundling is undefined.